Skip to content

Conversation

@cjeanner
Copy link

@cjeanner cjeanner commented Dec 3, 2025

No description provided.

@cjeanner cjeanner marked this pull request as draft December 3, 2025 14:23
- Use fully qualified module names (ansible.builtin.shell, ansible.builtin.set_fact)
- Enhance awk filtering with case-insensitive matching and bridge exclusion
- Improve task names for better clarity
- Add explicit cmd parameter for shell task

The improved filtering now excludes bridge interfaces and handles
case-insensitive MAC address matching more robustly.

AI Model: Generated using Auto (agent router designed by Cursor)
@cjeanner cjeanner force-pushed the refactor/values-prep branch 3 times, most recently from 502e0b3 to d017811 Compare December 9, 2025 14:45
@cjeanner cjeanner force-pushed the refactor/values-prep branch from d017811 to 9b14576 Compare December 17, 2025 13:41
@cjeanner cjeanner marked this pull request as ready for review December 17, 2025 13:42
- Use fully qualified module names (ansible.builtin.*) throughout
- Convert boolean values from yes/no to true/false
- Improve task names with proper capitalization and clarity
- Replace shell with command for simple oc commands
- Add explicit cmd parameter to all command/shell tasks
- Fix typos: 'woker' -> 'worker', 'accros' -> 'across'
- Fix grammar: 'run lsblk on each nodes' -> 'Run lsblk on each node'
- Add become flag where appropriate (iptables commands)

Optimize jq query in find-node-disks.yml:
- Combine multiple chained select() statements into a single select()
  with and conditions for better performance
- Validated query produces identical results:
  * Tested with local lsblk output containing disks with/without
    /boot partitions
  * Confirmed correct filtering of disks with /boot mounted children
  * Verified both original and optimized versions produce same output

This ensures consistency, better performance, and alignment with
Ansible best practices for module usage and task naming conventions.

AI Model: Generated using Auto (agent router designed by Cursor)
@cjeanner cjeanner force-pushed the refactor/values-prep branch from 9b14576 to 16ff7a3 Compare December 17, 2025 16:23
@cjeanner cjeanner marked this pull request as draft December 17, 2025 16:38
@cjeanner
Copy link
Author

I see issues with the way the disk is selected for LVMS - I'll make a new commit stack on-to the current ones. It will allow a better review/testing. but apparently, we can be slightly smarter here, and avoid any loop.

Refactor find-node-disks to:
- Only access the first node (node_0) instead of looping through 3 nodes
- Extract disk devices using lsblk on the first node
- Convert /dev/sdX devices to their stable /dev/disk/by-path/... symlinks using udevadm
- Store all by-path device paths in common_disks variable for reliable disk identification
@cjeanner cjeanner force-pushed the refactor/values-prep branch from 5b42697 to 4145c73 Compare December 17, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant